Skip to content

Add InlineGitBlame to Package Control#9410

Open
akostoth02 wants to merge 1 commit into
sublimehq:masterfrom
akostoth02:add-inlinegitblame
Open

Add InlineGitBlame to Package Control#9410
akostoth02 wants to merge 1 commit into
sublimehq:masterfrom
akostoth02:add-inlinegitblame

Conversation

@akostoth02
Copy link
Copy Markdown

  • I'm the package's author and/or maintainer.
  • I have read the docs.
  • I have tagged a release with a semver version number.
  • My package repo has a description and a README describing what it's for and how to use it.
  • My package doesn't add context menu entries. *
  • My package doesn't add key bindings. **
  • Any commands are available via the command palette.
  • Preferences and keybindings (if any) are listed in the menu and the command palette, and open in split view.
  • If my package is a syntax it doesn't also add a color scheme. ***
  • I use .gitattributes to exclude files from the package: images, test files, sublime-project/workspace.

My package is similar to Git Blame, however I would like to add it, because it shows the blame inline without any direct trigger. It works just like in VS Code for example. Similar, but still different :)
Also planning to add more useful features, maybe the exact change made for the line with the last commit. However i will try to keep it lean, as all things should be.

@deathaxe
Copy link
Copy Markdown
Contributor

deathaxe commented May 6, 2026

FWIW, GitGutter optionally shows blame info inline and in statusbar.

@akostoth02
Copy link
Copy Markdown
Author

Yes, i just created such a package, because i do not use most of it's features. I want this to be a standalone package for inline blames.
Also this runs a bit smoother, as the blame is loaded for the full file, when it's opened. The phantom is served by a cache.

There are still things to work on, but I thought it's in a shape already that could be published.

@kaste
Copy link
Copy Markdown
Contributor

kaste commented May 8, 2026

That looks fantastic!

Let's see what the reviewer bot says.

LGTM! @braver

(braver is not the bot.)

@kaste
Copy link
Copy Markdown
Contributor

kaste commented May 8, 2026

  • "base_file": "${packages}/InlineGitBlame/Default (InlineGitBlame).sublime-keymap",

That's not a standard name, and then you must set ... the key ... "user_file"? The reviewer will know that.

Also add them to "commands", the ctrl+shift+p thing, Command Palette. Preferences: ...

  • Because you prepared for that, add at BOF in your root.py
import sys

# kiss-reloader:
prefix = __spec__.parent + "."  # don't clear the base package
for module_name in [
    module_name
    for module_name in sys.modules
    if module_name.startswith(prefix) and module_name != __name__
]:
    del sys.modules[module_name]

(https://github.com/kaste/KissReloader)

so that the package hot-reloads if you ship updates.

  • There is bug 😭 . In md files, e.g. a README, I cannot reliably use arrow-down. It just jumps at EOL.

@braver
Copy link
Copy Markdown
Collaborator

braver commented May 9, 2026

(braver is not the bot.)

🤣

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 9, 2026

This PR adds InlineGitBlame.

Review for InlineGitBlame main-a0fc959-2026.05.08.11.14.00

- Common used command prefix is: inline_git_blame.
- Tip of main is tagged with 1.2.0. ✅
- This file only contains commented examples. Consider defining 'Example.sublime-keymap' and linking it from 'Main.sublime-menu'.
    File: Default.sublime-keymap

No failures

2 warnings:
- 'Main.sublime-menu' has no 'Package Settings' entry for key bindings of 'InlineGitBlame'
    File: Main.sublime-menu
- 'Main.sublime-menu' has no 'Package Settings' entry for 'InlineGitBlame'
    File: Main.sublime-menu


For more details on the report messages (for example how to resolve them), go to:
https://github.com/packagecontrol/st_package_reviewer/wiki

Repository: https://github.com/akostoth02/ST-InlineGitBlame

@braver
Copy link
Copy Markdown
Collaborator

braver commented May 9, 2026

  • Consider adding keybindings and settings entries to the command palette (example).
  • Not sure what the bot it complaining about with the main menu entries, but have a look (also check @kaste's comments).
  • Your entry in this PR has mixed indentation.
  • While messages about updates are good, people do tend to find them annoying if there are a lot of them. So I would advise to limit it to changes in UI or settings that users need to know about.

@kaste
Copy link
Copy Markdown
Contributor

kaste commented May 9, 2026

Not sure what the bot it complaining about with the main menu entries

I update the reviewer. The culprit is that "Inline Git Blame" is used but the package name is "InlineGitBlame".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants